Conversation
If the DNS change has not propagated yet to all nameservers, then it may
be that the first reachability success goes through but a second one
falis. in that case we are better off first trying for 'consecutive
success' before we proceed with the deploy
can be used in deploy.php like:
```
$testingStage->addBrancherServer("$APP_NAME")
->setLabels(['autodestroy=false', 'stage=acceptance', 'ci_ref=' . (\getenv('GITHUB_HEAD_REF') ?: 'none')])
->setBrancherReachabilityCheckCount(6) // Amount of consecutive checks required
->setBrancherReachabilityCheckInterval(10); // Amount of seconds between checks
```
vdloo
pushed a commit
to ByteInternet/hypernode-deploy-configuration
that referenced
this pull request
Dec 24, 2025
so we can test both PRs without merging both: ByteInternet/hypernode-deploy-configuration#55 #184
poespas
reviewed
Dec 24, 2025
vdloo
force-pushed
the
more-robust-dns-check
branch
2 times, most recently
from
6984992 to
49ab333
Compare
poespas
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the DNS change has not propagated yet to all nameservers, then it may be that the first reachability success goes through but a second one fails. in that case we are better off first trying for 'consecutive success' before we proceed with the deploy
can be used in deploy.php like:
also see ByteInternet/hypernode-deploy-configuration#55